cli: fix legacy parser options for Py3.9.8 (Sopel 8.x) #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hack adds a prefix to the "dest" of the legacy options added to the main parser. It works because these options are not actually used by the legacy subparser: they exists only to trick the help message into something usable by end-users. It's rather ugly, but at this point we already know that the "legacy" subparser trick is ugly. We are only fixing the issue introduced by Python 3.9.8 that "fixed" something in argparse that broke our use-case. Let's not delve into that for now.
Exirel
added
the
Bugfix
|
FWIW, the patch to revert the change that makes this patch necessary is awaiting merge and backporting. python/cpython#29525 |
4 tasks
|
Open to suggestions for why we should do this anyway, even though Python 3.9.9 reverted the responsible change. If the consensus is to skip this "hack" and wait for further news (my inclination), that's the reason for which I've left #2210 open. |
|
Given that most of the parser will be reworked to remove deprecated options with a better "default action" system... I think we can close this and I'll make sure to include that question into the new version. |
dgw
added
the
Declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Same as #2211 but for the current development version (8.x). I hope Github Action will pass!
Checklist
make qa(runsmake qualityandmake test)