wiktionary: allow for multi-line etymologies #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically "multi-paragraph", but that's clunky to say. If the concatenated etymology is too long to fit in an IRC line, it's safely truncated by the existing logic to handle overly long output. This patch definitely makes me want to give wiktionary the same kind of makeover that wikipedia got a while back. Which is to say: a proper parser-based implementation instead of...whatever you call this.
dgw
added
the
Bugfix
Exirel
approved these changes
Dec 9, 2021
dgw
added a commit
that referenced
this pull request
Dec 11, 2021
wiktionary: allow for multi-line etymologies
dgw
added a commit
that referenced
this pull request
Dec 11, 2021
wiktionary: allow for multi-line etymologies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Multi-paragraph etymologies no longer get truncated to only the last line.
If the concatenated etymology is too long to fit in an IRC line, it's safely truncated by the existing logic to handle overly long output.
This patch definitely makes me want to give wiktionary the same kind of makeover that wikipedia got a while back. Which is to say: a proper parser-based implementation instead of...whatever you call this.
Checklist
make qa(runsmake qualityandmake test)