adminchannel: fix unmatchable caret in regex #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`configureHostMask` has had an unmatchable caret in one of its regular expressions since 2014. The fix for master/8.0 will be more like a minor refactor; this is just a patch to fix the obvious bug for stable.
4 tasks
Exirel
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
configureHostMaskhas had an unmatchable caret in one of its regular expressions since 2014. The fix for master/8.0 will be more like a minor refactor; this is just a patch to fix the obvious bug for stable.Checklist
make qa(runsmake qualityandmake test)Notes
Merging to
backports-7.1.7, which is where I've been staging all of the backported patches that were originally merged tomaster. Doing it this way (instead of sending this to7.1.x) lets me avoid an annoying rebase later.