reddit: handle image preview links #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
reviewed
Feb 5, 2022
half-duplex
force-pushed
the
reddit-preview-links
branch
from
c6af8ff
to
81f3ca4
Compare
dgw
approved these changes
Feb 6, 2022
dgw
added a commit
that referenced
this pull request
Feb 10, 2022
reddit: handle image preview links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The reddit plugin currently does not handle preview links like this, which users sometimes mistakenly post ("Copy image link" instead of "Copy link").
https://preview.redd.it/rgcetuc1rmf81.jpg?width=576&auto=webp&s=61de9945ce109cefe95cda589c18d434b2d23553
It falls through to url.py, which fails to find a title.
This changes the reddit.py image link handling to also catch preview links, and show both the comment and full-res links in that case.
pytest is currently exploding on master and I don't know why so uh. CI is doing my QA for me
Checklist
make qa(runsmake qualityandmake test)