Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: replace pkg_resources with importlib.metadata #2261

Merged
merged 7 commits into from
Mar 1, 2022
Merged

Commits on Feb 26, 2022

  1. init: replace pkg_resources version fetch with importlib

    Needs a backport package until we no longer support Python 3.7; stdlib
    gained `importlib.metadata` in Python 3.8.
    
    I should note that installing with `-r dev-requirements.txt` will always
    (currently) install the `importlib_metadata` backport because of Sphinx.
    dgw committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    ac9b4e1 View commit details
    Browse the repository at this point in the history
  2. lifecycle: replace pkg_resources version parsing with packaging's

    Unfortunately this one is *not* yet part of the stdlib in any Python
    release, but there's no point in removing only *most* uses of the older
    `pkg_resources` library. Gotta do them *all*.
    dgw committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    37575e6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    307ad5a View commit details
    Browse the repository at this point in the history
  4. plugins.handlers: use importlib EntryPoint model

    Adapted the `get_meta_description()` for `EntryPointPlugin` to return
    the expected format. Could alternatively change the expectation of
    `test_get_label_entrypoint()`.
    dgw committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    6b15c3d View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2022

  1. plugins.handlers: decouple "entry point" concept from setuptools

    As the Python packaging docs say, entry points are now a PyPA-defined
    interoperability specification not confined to packages built using
    `setuptools`, and we should update our docs to reflect that.
    
    See https://packaging.python.org/en/latest/specifications/entry-points/
    dgw committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    f7c6ea3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    53d5c26 View commit details
    Browse the repository at this point in the history
  3. docs: update entry point definition in plugin terms

    It's not a "setuptools entry point"; it's an "entry point group".
    dgw committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    a7dc9ce View commit details
    Browse the repository at this point in the history