tell: catch missing message before it causes an exception #2264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a regression introduced in v7.1.3 by #2162, backported to the 7.1.x branch as 0dec496. (Yep, this one's a mea culpa.)
Previously, the code was sort-of safe due to a strange use of
trigger.group(2).lstrip([…])
. The new code, usingtrigger.group(2).split()
instead, did not ensure that it actually gets enough values out of the split. I chose instead to make sure enough "words" exist in the command before performing the split.Checklist
make qa
(runsmake quality
andmake test
)Acknowledgements
Thanks to monaco (@hedho) for reporting this via logs on our IRC channel.