deps: forget about python_version specifier for importlib_metadata
#2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My clean install of Python 3.10 on Ubuntu 20.04 (via deadsnakes/ppa) came with an old version of `importlib_metadata` that tripped up the fallback logic I so carefully included. Rather than contort the import logic, let's just use the backport until Sopel no longer supports Python versions where stdlib can't replace it.
4 tasks
Exirel
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My clean install of Python 3.10 on Ubuntu 20.04 (via deadsnakes/ppa) came with an old version of
importlib_metadatathat tripped up the fallback logic I so carefully included.Rather than contort the import logic, let's just use the backport until Sopel no longer supports Python versions where stdlib can't replace it entirely.
Checklist
make qa(runsmake qualityandmake test)Notes
The test suite passes on my py3.10 env with this patch, except for a few
DeprecationWarnings (from third-party code) that I'd like to try to mitigate without adding transitive deps into our requirements again. Did too much of that in 7.x.1311 passed, 8 xfailed, 4 warningsis still a great sight to see. I'd just rather see1311 passed, 8 xfailedinstead. 😛