Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: default to use_ssl=True, port=6697 #2277

Merged
merged 1 commit into from
May 18, 2022

Conversation

half-duplex
Copy link
Member

@half-duplex half-duplex commented May 13, 2022

Description

Replace the defaults use_ssl=False; port=6667 with use_ssl=True; port=6697 and update associated docs.

I replaced ini e.g. use_ssl=on with use_ssl=true to match what the sopel configurator produces.

It would be neat to check the connection/cert and handhold a bit through that setup, but that's... less trivial

⚠️ This is a breaking change for users who rely on the defaults in their config files.
The configurator (at least the one in master) does write those lines even if they're left default, so this is probably not all too many users.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
    Well... No unexpected errors. We still have py3.10 issues =|
  • I have tested the functionality of the things this change touches

@half-duplex half-duplex added this to the 8.0.0 milestone May 13, 2022
@half-duplex half-duplex added Breaking Change Stuff that probably should be mentioned in a migration guide Core/Networking labels May 13, 2022
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can feel the sanity building up.

@dgw dgw merged commit a592330 into sopel-irc:master May 18, 2022
@half-duplex half-duplex deleted the default-ssl-on branch May 18, 2022 16:41
@half-duplex half-duplex restored the default-ssl-on branch May 14, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Stuff that probably should be mentioned in a migration guide Core/Networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants