Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: don't manually hunt for CA paths #2278

Merged
merged 1 commit into from
May 21, 2022
Merged

config: don't manually hunt for CA paths #2278

merged 1 commit into from
May 21, 2022

Conversation

half-duplex
Copy link
Member

@half-duplex half-duplex commented May 13, 2022 •
edited
Loading

Description

It was agreed in #2256 that we should probably not be hunting for CA paths ourselves. This removes that, and allows ssl to use its default (openssl's default). This should be an invisible change.

To rebase this on top of or beneath #2256: discard this PR's backends.py changes (wrap_socket() had no sane default for ca_certs)

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
    Contemporary caveats apply.
  • I have tested the functionality of the things this change touches

@half-duplex half-duplex added Housekeeping Code cleanup, removal of deprecated stuff, etc. Core/Networking labels May 13, 2022
@half-duplex half-duplex added this to the 8.0.0 milestone May 13, 2022
@dgw
Copy link
Member

dgw commented May 13, 2022

Since #2256 is approved, let's give @Exirel a chance to squash it down and then rebase this on top of it. We could even change the base branch of this PR to that one and go for the "stacked PRs" workflow, but uh… I don't think anyone wants to mess with that. 🙃

Exirel
Exirel approved these changes May 15, 2022
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, yet I haven't tested it myself.

dgw
dgw reviewed May 19, 2022
View reviewed changes
sopel/config/core_section.py Outdated Show resolved Hide resolved
@dgw dgw merged commit 984e1b9 into sopel-irc:master May 21, 2022
@half-duplex half-duplex deleted the no-ca-hunt branch May 24, 2022 21:29
@half-duplex half-duplex mentioned this pull request Jun 9, 2022
Merged
4 tasks
@half-duplex half-duplex restored the no-ca-hunt branch May 14, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw left review comments

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Core/Networking Housekeeping Code cleanup, removal of deprecated stuff, etc.
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@half-duplex @dgw @Exirel