Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: replace deprecated dnspython method #2304

Merged
merged 1 commit into from
Jun 26, 2022
Merged

url: replace deprecated dnspython method #2304

merged 1 commit into from
Jun 26, 2022

Conversation

dgw
Copy link
Member

@dgw dgw commented Jun 10, 2022

Description

The query() method has been deprecated, and was generating warnings in our CI logs. Fingers crossed that the dnspython maintainers will keep the old method around until their next major version, which Sopel (even on the stable branch) excludes in its requirements. (This is my excuse for not bothering to backport the change to 7.1.x.)

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw
url: replace deprecated dnspython method
97e8520 
The `query()` method has been deprecated, and was generating warnings in
our CI logs. Fingers crossed that the `dnspython` maintainers will keep
the old method around until their next major version, which Sopel (even
on the stable branch) excludes in its requirements.
@dgw dgw added the Housekeeping Code cleanup, removal of deprecated stuff, etc. label Jun 10, 2022
@dgw dgw added this to the 8.0.0 milestone Jun 10, 2022
@dgw dgw requested a review from a team June 14, 2022 00:36
Exirel
Exirel approved these changes Jun 25, 2022
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the changelog for dnspython, it looks like it should be fine.

@dgw dgw merged commit 89d631d into master Jun 26, 2022
@dgw dgw deleted the url-deprecated-dns branch June 26, 2022 05:28
@dgw
Copy link
Member Author

dgw commented Jun 26, 2022

I'm a happy 🐈.

## BEFORE merging this patch:

================= 1319 passed, 8 xfailed, 1 warning in 35.78s ==================

## AFTER merging this patch:

======================= 1319 passed, 8 xfailed in 36.28s =======================

Yeah, I realize this will throw a small wrench into #2285 (just a rebase, which was already going to be needed), but now we don't have to see this DeprecationWarning any more while work continues on that front.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Housekeeping Code cleanup, removal of deprecated stuff, etc.
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dgw @Exirel