irc, memories: fix handling QUITs, and prevent infinite failed-connection retries #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
added
High Priority
Bugfix
dgw
approved these changes
Jun 11, 2022
dgw
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This started with our instance of Sopel running from source with the bot becoming unresponsive after a user quit the server: there was a bug in how
SopelIdentifierMemorydeals withNone in memory. This caused an unexpected exception at the wrong place, which put the bot in a weird unstable state from which it doesn't recover.I also fixed the case where an SSL connection error would block the bot in an infinite restart loop.
I'm still not sure the message handling is safe, but at least this particular cause is fixed.
Checklist
make qa(runsmake qualityandmake test)