Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip: allow praw from v4 to v7 #2319

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Jul 13, 2022

Description

Tin, fix #1903.

I've check a set of URLs (user, subreddit, comments, image, and video) with praw versions 6.5 and 7.6 and everything worked so far. I've read their changelog and didn't see anything that would generate an error on our side.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added the Housekeeping Code cleanup, removal of deprecated stuff, etc. label Jul 13, 2022
@Exirel Exirel added this to the 8.0.0 milestone Jul 13, 2022
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They dropped Python 3.6 in a point release (praw 7.6.0), but I guess we can cross the 3.7 bridge if necessary later. I'll be optimistic for now that modern pip is smart enough to fetch the last compatible release if the latest doesn't support the current Python version.

(Could be famous last words, I know.)

@dgw dgw merged commit 12a05ad into sopel-irc:master Jul 15, 2022
@Exirel Exirel deleted the reddit-upgrade-praw branch April 8, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping Code cleanup, removal of deprecated stuff, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reddit: Support PRAW 7
2 participants