Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicode_info: Use unicodedata2, if available #2349

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

SnoopJ
Copy link
Contributor

@SnoopJ SnoopJ commented Sep 14, 2022

Description

This PR adds support for the unicodedata2 library to the unicode_info plugin, allowing the plugin to report information about codepoints from more modern versions of Unicode than the one shipped with the stdlib of the Python executing the bot.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw dgw added the Feature label Sep 17, 2022
@dgw dgw added this to the 8.0.0 milestone Sep 17, 2022
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy feature bump. The next challenge is to figure out where this should be documented.

All the more reason to pick up work on https://github.com/sopel-irc/plugin-db again. (If you go check it out, make sure you're on the prototype branch.)

sopel/modules/unicode_info.py Show resolved Hide resolved
@dgw dgw merged commit 4e0a386 into sopel-irc:master Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants