Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unicode_info: ignore type check on unicodedata2 #2361

Merged
merged 1 commit into from
Nov 1, 2022
Merged

unicode_info: ignore type check on unicodedata2 #2361

merged 1 commit into from
Nov 1, 2022

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Oct 14, 2022

Description

  • ignore import error because unicodedata2 doesn't have a stub
  • ignore no-redef error because unicodedata2 is optional and it has the same interface as unicodedata

Also modified some comments because nitpicking is my pride.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added Bugfix Generally, PRs that reference (and fix) one or more issue(s) Housekeeping Code cleanup, removal of deprecated stuff, etc. labels Oct 14, 2022
@Exirel Exirel added this to the 8.0.0 milestone Oct 14, 2022
dgw
dgw reviewed Oct 14, 2022
View reviewed changes
sopel/modules/unicode_info.py Outdated Show resolved Hide resolved
@dgw dgw added Tests and removed Bugfix Generally, PRs that reference (and fix) one or more issue(s) labels Oct 14, 2022
dgw
dgw approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poor GHA will have to run CI a third time for these changes when you squash, but oh well. Can't [skip ci] on the final, merge-ready state of a PR because of our required checks. 😁

@dgw
Copy link
Member

dgw commented Oct 22, 2022

@Exirel ping for squash

@Exirel @dgw
unicode_info: ignore type check on unicodedata2
c728d52 
* ignore import error because unicodedata2 doesn't have a stub
* ignore no-redef error because unicodedata2 is optional and
  it has the same interface as unicodedata

Also modified some comments because nitpicking is my pride.

Co-authored-by: dgw <dgw@technobabbl.es>
@Exirel Exirel force-pushed the unicode-info-ignore-type-check branch from 6cdbe4d to c728d52 Compare November 1, 2022 11:27
@Exirel
Copy link
Contributor Author

Exirel commented Nov 1, 2022

I DID IT.

@dgw dgw merged commit 53c5543 into sopel-irc:master Nov 1, 2022
@Exirel Exirel deleted the unicode-info-ignore-type-check branch April 8, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Housekeeping Code cleanup, removal of deprecated stuff, etc. Tests
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Exirel @dgw