Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xkcd: switch to DDG for keyword lookup #2376

Merged
merged 1 commit into from
Dec 15, 2022
Merged

xkcd: switch to DDG for keyword lookup #2376

merged 1 commit into from
Dec 15, 2022

Conversation

dgw
Copy link
Member

@dgw dgw commented Nov 5, 2022

Description

Bing has become supremely unreliable. In a shocking turn of events, it seems that DuckDuckGo no longer vomits on the long string of -site: operators used in this plugin.

Current master:

16:03:35 <~dgw> ,xkcd group chat
16:03:36 <SopelTest> dgw: Could not find any comics for that query.

# [Ed. note: Same for any other non-integer query]

With this patch:

16:31:03 <~dgw> ,xkcd group chat
16:31:04 <SopelTest> [xkcd] Group Chat Rules | Alt-text: There's no group chat member more enigmatic than the cool
                     person who you all assume has the chat on mute, but who then instantly chimes in with no delay
                     the moment something relevant to them is mentioned. | https://xkcd.com/2235

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches (see before/after above)

Notes

Someone else can investigate backporting this to 7.1.x if they like, but it's easy enough for someone to just use the newer xkcd.py in an old bot if they want. The sopel.modules.search stuff hasn't really changed. I don't particularly want to spend time on things that don't progress 8.0 at this point.

This is the simplest, fastest way to get .xkcd some keywords working again, because .ddg output works as expected. I might still try to fix Bing search separately… Had some small amount of success by fussing with the user agent Sopel sends, but it still wouldn't reliably obey site: operators. (It's probably picking up ads on the page; I would bet the HTML has changed.)

Bing has become supremely unreliable. In a shocking turn of events, it
seems that DuckDuckGo no longer vomits on the long string of `-site:`
operators used in this plugin.
@dgw dgw added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Nov 5, 2022
@dgw dgw added this to the 8.0.0 milestone Nov 5, 2022
@dgw dgw requested a review from a team November 5, 2022 21:42
Copy link
Contributor

@SnoopJ SnoopJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine to me since it's "just" a different configuration, and you've tested it. Especially if Bing is outright failing that often

@dgw dgw merged commit 0508e7b into master Dec 15, 2022
@dgw dgw deleted the xkcd-use-ddg branch December 15, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants