Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reqs: do not require sopel-py #2415

Merged
merged 1 commit into from
Feb 26, 2023
Merged

reqs: do not require sopel-py #2415

merged 1 commit into from
Feb 26, 2023

Conversation

dgw
Copy link
Member

@dgw dgw commented Feb 24, 2023

Description

Tin. Makes more sense to cleanly drop this in 8.0, rather than wait for 8.1.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

Notes

I was already thinking along these lines, but IRC discussion this morning pushed me the rest of the way.

Makes more sense to cleanly drop this in 8.0, rather than wait for 8.1.
@dgw dgw added the Breaking Change Stuff that probably should be mentioned in a migration guide label Feb 24, 2023
@dgw dgw added this to the 8.0.0 milestone Feb 24, 2023
@dgw dgw requested a review from a team February 24, 2023 17:33
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@dgw dgw merged commit 5a590f5 into master Feb 26, 2023
@dgw dgw deleted the no-py-by-default branch February 26, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Stuff that probably should be mentioned in a migration guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants