Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

irc: Improve output for common connection errors #2430

Merged
merged 5 commits into from
May 23, 2023
Merged

irc: Improve output for common connection errors #2430

merged 5 commits into from
May 23, 2023

Commits on Mar 24, 2023

  1. irc: deprecate AbstractBot.on_error 

    This method was used for the asynchat backend implementation.
It is now deprecated and must not be used.

Co-authored-by: dgw <dgw@technobabbl.es>
    @Exirel @dgw
    Exirel and dgw committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    753a39e View commit details
    Browse the repository at this point in the history

  2. irc: user-friendly messages on connection error 

    These error are now managed with a more user-friendly message, and the
exception is sent to the exception log file:

* SSL certificate validation error
* SSL generic error
* Connection timeout (socket timeout, not IRC timeout)
* Invalid hostname
* Unable to connect (temporary disconnected, host unreachable, etc.)

If we inspect the OSError's errno we could provide a more fine-grained
error handling.

We could, also, improve the connection retry for certain errors.
    @Exirel
    Exirel committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    b6c5e86 View commit details
    Browse the repository at this point in the history

  3. irc: friendler message on certificate verification failure 

    Co-authored-by: James Gerity <snoop.jedi@gmail.com>
    @Exirel @SnoopJ
    Exirel and SnoopJ authored Mar 24, 2023
    Configuration menu
    Copy the full SHA
    3a81afa View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. irc: separate ConnectionError from OSError 

    Co-authored-by: dgw <dgw@technobabbl.es>
    @Exirel @dgw
    Exirel and dgw committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    96a52ac View commit details
    Browse the repository at this point in the history

  2. irc: isolate the socket connection attempt 

    Co-authored-by: dgw <dgw@technobabbl.es>
    @Exirel @dgw
    Exirel and dgw committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    c4a34f7 View commit details
    Browse the repository at this point in the history