build: pin urllib3 to <2.0 for now #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI is broken with urllib3 2.x, but the specific package that fails our tests (vcrpy) is not moving very swiftly to release a fix. While they debate which versions of urllib3 to support, we just want to have working CI so we can start merging our slowly growing PR backlog. Because urllib3 is a transitive dependency of requests, it belongs in the regular requirement list even though this pin is to fix tests.
Exirel
approved these changes
May 21, 2023
Certainly, as soon as there is a merge commit to reference in said issue. 😁 |
This was referenced May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is broken with urllib3 2.x, but the specific package that fails our tests (vcrpy) is not moving very swiftly to release a fix.
While they debate which versions of urllib3 to support, we just want to have working CI so we can start merging our slowly growing PR backlog.
Because urllib3 is a transitive dependency of requests, it belongs in the regular requirement list even though this pin is to fix tests.
Checklist
make qa(runsmake qualityandmake test)Notes
This has been blocking us for about two weeks, and that's more than long enough to warrant a temporary dependency pin (even though I prefer to avoid them, in general). I'm subscribed to the upstream issue already pointed out by @SnoopJ, for notifications relevant to undoing this.