build, meta: drop Python 3.7 support, checks, and CI job #2500

dgw · 2023-08-02T07:14:13Z

Description

This fulfills the last "Finally letting the dead snakes lie." part of the 8.0.0 milestone's description. Python 3.7 was officially EOL'd as of a month ago, on June 27.

Checklist

I have read CONTRIBUTING.md
I can and do license this contribution under the EFLv2
No issues are reported by make qa (runs make quality and make test)
- (As of when I prepped the patch.)
I have tested the functionality of the things this change touches
- When I wrote it, I did, with make test etc. (Now it needs a rebase for retesting.)

Conflict notes

@SnoopJ and @Exirel arrived at similar conclusions for dealing with aliases in plugins/rules.py; this has a conflict with 098d8c3, but the approaches are quite similar. That and b0693b7 are both from #2471, which touched a bunch of stuff (so I knew the risk of conflicts with this relatively long-lived housekeeping branch was inevitable).

The only other little conflict is more directly my fault. While I set @SnoopJ loose on my todo list for #2471 to get it done faster, #2480—specifically, 85f8b82—is all me. 🙈

Guess I have to rebase this one, huh? Damn, I love merging branches that diverged long before master because the history graph looks cool, but sometimes it's just not meant to be. 😅

Special thanks

…to the other maintainers for humoring me when I said I wanted to reach #2500 and make this PR a numerical milestone as well as a development one. You're all awesome for tossing in extra issues & PRs to get us here! ❤️

Linking to just `/3/` is admittedly risky, because item/anchor locations can change across Python versions. Bumping the links from 3.7 to 3.11 gives us a few more years of not needing to touch them.

Can't drop the `importlib_metadata` requirement yet, though. We use some stuff elsewhere that isn't stable in stdlib until py3.10.

Played with using intentionally wrong types in the definition of a `PluginMetaDescription` and running `mypy` against it, but didn't see any (new) errors flagged over that. Maybe I did it wrong, but it took enough work shuffling docstrings around that I'm committing this anyway.

The test covering `_chunks()` still passes, so hooray!

Regular `dict` is promised to maintain insertion order as of Python 3.7 (which means this could have been done sooner, but it got forgotten, so we're doing it at the point of dropping Python <3.8 instead).

dgw · 2023-08-02T07:45:33Z

No issues are reported by make qa (runs make quality and make test)

(As of when I prepped the patch.)

Well, now the latest version of pyflakes (updated from 3.0.1 to 3.1.0) raises "F811 Redefinition of unused name" for:

sopel/sopel/plugins/rules.py

Line 1782 in e63afba

def execute_handler(bot, trigger):

The name execute_handler is defined earlier, but never used:

sopel/sopel/plugins/rules.py

Line 1766 in e63afba

execute_handler = handler

Upstream seems to consider this as "Working as intended" (PyCQA/pyflakes#780), so I guess we'll have to if: ... else: this one now. 🙁

SnoopJ

LGTM, most of this is pretty straightforward housekeeping.

sopel/bot.py

sopel/plugins/handlers.py

sopel/plugins/rules.py

sopel/plugins/handlers.py

Not doing exactly as the comment says because different Rule subclasses pass aliases as either tuple or list depending on how whoever wrote the subclass was feeling that day. Instead, let's simplify the code to do everything in one step, and unpack the `aliases` iterable so its type won't even matter. Co-authored-by: SnoopJ <snoopjedi@gmail.com>

dgw · 2023-08-03T04:59:01Z

Having whittled down most of the open threads from @SnoopJ and myself, I figured it's worth seeing if Exi has free time later this week(end) to chime in.

`importlib.metadata` officially starts existing in Python 3.8, and we are removing support for Python 3.7 before Sopel 8's stable release. That means we can use the stdlib approach here to get the version string for an entry-point plugin, and drop another `import importlib_metadata`. I can't wait for Python 3.9's EOL... We can remove `importlib_metadata` completely then.

half-duplex

LGTM, a couple other grep results:

modules/tld.py has a "py<3.5" comment
I think importlib_metadata can be removed from a few more places, unless 3.8 doesn't have importlib.metadata.EntryPoint()

SnoopJ · 2023-08-03T16:52:47Z

I think importlib_metadata can be removed from a few more places, unless 3.8 doesn't have importlib.metadata.EntryPoint()

It does have EntryPoint but I believe the behavior of entry_points() changes subtly between 3.9 and 3.10 which keeps the dependency around? I don't know the details myself, but see this comment

dgw · 2023-08-03T17:02:40Z

modules/tld.py has a "py<3.5" comment

My pattern missed that because of the <, whoops. Thanks.

As of Python 3.5, we can do this. It's overdue.

half-duplex

It does have EntryPoint but I believe the behavior of entry_points() changes subtly between 3.9 and 3.10 which keeps the dependency around? I don't know the details myself, but see this comment

I read that as being about entry_points(filter=) only, not the EntryPoint class itself, but I don't have py3.8 handy to test with.

Either way, we still need the dependency for now, so eh. 🚀

importlib.metadata.EntryPoint *shouldn't* differ from Python 3.8 onward, unless there's something missing from the documentation. If this breaks stuff on older Python releases (I'm on 3.10 locally), we will defer this change until we drop 3.9 as planned per the code comments.

dgw · 2023-08-03T18:31:45Z

I decided to throw replacing importlib_metadata usage under test/ at the CI for fun. Nothing broke on 3.8/3.9, so 🚀 I guess.

sopel/modules/announce.py

Exirel

I love importlib.metadata. I love the walrus operator (:=). I love removing Py3.7.

dgw added the Housekeeping Code cleanup, removal of deprecated stuff, etc. label Aug 2, 2023

dgw added this to the 8.0.0 milestone Aug 2, 2023

dgw added 6 commits August 2, 2023 00:26

build, meta: drop Python 3.7 support, checks, and CI job

45ce17c

docs/docstrings: replace links to Python 3.7 docs w/links to 3.11 pages

4d2f19c

Linking to just `/3/` is admittedly risky, because item/anchor locations can change across Python versions. Bumping the links from 3.7 to 3.11 gives us a few more years of not needing to touch them.

sopel: importlib_metadata backport -> stdlib importlib.metadata

a903e5d

Can't drop the `importlib_metadata` requirement yet, though. We use some stuff elsewhere that isn't stable in stdlib until py3.10.

announce: simplify chunking loop to use walrus operator

451a36e

The test covering `_chunks()` still passes, so hooray!

irc.isupport: simplify OrderedDict -> dict

8ad45b7

Regular `dict` is promised to maintain insertion order as of Python 3.7 (which means this could have been done sooner, but it got forgotten, so we're doing it at the point of dropping Python <3.8 instead).

dgw force-pushed the rm-py3.7 branch from 50393c9 to e63afba Compare August 2, 2023 07:33

dgw requested a review from a team August 2, 2023 07:33

dgw force-pushed the rm-py3.7 branch 2 times, most recently from 55fe4a7 to f675d27 Compare August 2, 2023 07:58

SnoopJ approved these changes Aug 2, 2023

View reviewed changes

sopel/bot.py Show resolved Hide resolved

sopel/plugins/handlers.py Show resolved Hide resolved

sopel/plugins/rules.py Outdated Show resolved Hide resolved

sopel/plugins/rules.py Outdated Show resolved Hide resolved

sopel/plugins/handlers.py Show resolved Hide resolved

dgw commented Aug 3, 2023

View reviewed changes

sopel/plugins/handlers.py Show resolved Hide resolved

dgw force-pushed the rm-py3.7 branch from f675d27 to b3f5458 Compare August 3, 2023 02:04

dgw force-pushed the rm-py3.7 branch from b3f5458 to b2ea7ae Compare August 3, 2023 04:55

dgw requested a review from Exirel August 3, 2023 04:58

dgw added 2 commits August 2, 2023 22:11

plugins.rules: fix newly detected case of F811 in pyflakes 3.1.0+

314c8a2

dgw force-pushed the rm-py3.7 branch from b2ea7ae to 57b692c Compare August 3, 2023 05:11

half-duplex reviewed Aug 3, 2023

View reviewed changes

tld: be more specific about JSONDecodeError instead of ValueError

c743861

As of Python 3.5, we can do this. It's overdue.

half-duplex approved these changes Aug 3, 2023

View reviewed changes

Exirel reviewed Aug 8, 2023

View reviewed changes

sopel/modules/announce.py Show resolved Hide resolved

Exirel approved these changes Aug 8, 2023

View reviewed changes

dgw merged commit d58d6a7 into master Aug 9, 2023

dgw deleted the rm-py3.7 branch August 9, 2023 07:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build, meta: drop Python 3.7 support, checks, and CI job #2500

build, meta: drop Python 3.7 support, checks, and CI job #2500

dgw commented Aug 2, 2023 •

edited

Loading

dgw commented Aug 2, 2023

SnoopJ left a comment

dgw commented Aug 3, 2023

half-duplex left a comment

SnoopJ commented Aug 3, 2023

dgw commented Aug 3, 2023

half-duplex left a comment

dgw commented Aug 3, 2023

Exirel left a comment

build, meta: drop Python 3.7 support, checks, and CI job #2500

build, meta: drop Python 3.7 support, checks, and CI job #2500

Conversation

dgw commented Aug 2, 2023 • edited Loading

Description

Checklist

Conflict notes

Special thanks

dgw commented Aug 2, 2023

SnoopJ left a comment

Choose a reason for hiding this comment

dgw commented Aug 3, 2023

half-duplex left a comment

Choose a reason for hiding this comment

SnoopJ commented Aug 3, 2023

dgw commented Aug 3, 2023

half-duplex left a comment

Choose a reason for hiding this comment

dgw commented Aug 3, 2023

Exirel left a comment

Choose a reason for hiding this comment

dgw commented Aug 2, 2023 •

edited

Loading