Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add capabilities test cases for trailing space handling #2505

Merged
merged 2 commits into from
Sep 16, 2023
Merged

test: add capabilities test cases for trailing space handling #2505

merged 2 commits into from
Sep 16, 2023

Commits on Sep 4, 2023

  1. test: add capabilities test cases for trailing space handling 

    Some IRCds include trailing space in capability lists, and this is not a
spec violation. Default `.split()` behavior in Python should handle it
fine, but it's also good to be explicit that we expect the default
behavior, through tests.
    @dgw
    dgw committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    495ce9c View commit details
    Browse the repository at this point in the history

  2. test: fix incorrect capability NAK test names 

    It's not much, but it's honest work.

I was going to do some type-hint cleanup too, but there are plenty of
warnings in the `test/` directory because we haven't been checking it.
That sort of work should be done in its own PR(s) rather than as
incidental cleanup "because I'm already touching this file".
    @dgw
    dgw committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    0c86842 View commit details
    Browse the repository at this point in the history