Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins.handlers: fix some PyFilePlugin logic errors #2633

Merged
merged 2 commits into from
Oct 20, 2024
Merged

plugins.handlers: fix some PyFilePlugin logic errors #2633

merged 2 commits into from
Oct 20, 2024

Commits on Sep 12, 2024

  1. plugins.handlers: fix incorrect PyFilePlugin construction 

    Two things:

1. `submodule_search_locations` is expected to be a list, according to
   Python's documentation for `importlib.machinery.ModuleSpec`.
2. The new `module` being inserted into `sys.modules` before checking if
   its spec had a valid `loader` bothered me, so I reordered the steps.
    @dgw
    dgw committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    86efe41 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. test: add regression test for PyFilePlugin folders w/submodules

    @dgw
    dgw committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    54372e6 View commit details
    Browse the repository at this point in the history