Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M3 final deployment #105

Merged
merged 23 commits into from
Apr 26, 2024
Merged

M3 final deployment #105

merged 23 commits into from
Apr 26, 2024

Conversation

petertheprocess
Copy link
Contributor

No description provided.

yixuan-zhou-uzh and others added 23 commits April 26, 2024 12:10
@yixuan-zhou-uzh
[fix] the room theme to be loading
052cb7e
@yixuan-zhou-uzh
[fix] the leaderboard not changing after user quitting
8b01aaa 
[fix] format fixing for the room and ldboard
@yixuan-zhou-uzh @petertheprocess
[fix] the room theme to be loading
7d8fbf0
@yixuan-zhou-uzh @petertheprocess
[fix] the leaderboard not changing after user quitting
03fe5b0 
[fix] format fixing for the room and ldboard
@petertheprocess
Merge branch 'M3-ui-modify' of github.com:sopra-fs24-group-09/sopra-f…
c59e0dd 
…s24-group-09-client into M3-ui-modify
@petertheprocess
comment debug log
c4f1d61
@petertheprocess
Merge pull request #91 from sopra-fs24-group-09/M3-ui-modify
1d496fa 
M3 UI modify
@petertheprocess
Volume tuning by useImperativeHandle rather than props,
feed3cd 
which can avoid refresh on playing audio.
@petertheprocess
[fix] lift volume state outside, fix mute behavior
ed4f404
@petertheprocess
Merge pull request #92 from sopra-fs24-group-09/M3-volume-tuning
57e9b82 
M3 volume tuning fix
@Haaaan1
Add manually reload rooms function
d195885
@petertheprocess
Merge pull request #93 from sopra-fs24-group-09/feature-relaod-rooms
b0237d5 
Add manually reload rooms function
@petertheprocess
Prevent unsupported broswer play game. fix #94
c909188
@zihanltesla
websocket forward error message
e7ab79f
@zihanltesla
Add nav to lobby
8fce7d5
@petertheprocess
Merge pull request #96 from sopra-fs24-group-09/feature/chrome-only-c…
367d12c 
…heck

Prevent unsupported broswer play game. fix #94
@petertheprocess
Merge pull request #97 from sopra-fs24-group-09/M3-integration-test-a…
757c8b0 
…dd-response

fix #99
@petertheprocess
Fetch the latest roomlist before enter room action. fix #98
62c36c5
@petertheprocess
Merge pull request #100 from sopra-fs24-group-09/M3-check-roomlist-be…
5e9ce4d 
…fore-enter

M3 check roomlist before enter
@petertheprocess
If lose connection (network err or ws disconnected) with server, clea…
77a14c9 
…n all storage and alert user. fix #103
@petertheprocess
Merge pull request #104 from sopra-fs24-group-09/M3-lobby-request-exc…
bdaeeaf 
…eption-handle

Lobby requset exception handle
@petertheprocess
fix lint
7186cf2
@petertheprocess
Merge pull request #85 from sopra-fs24-group-09/M3-intergration-test
b2b4e09 
M3 intergration PR close #41 #46 #47 #67 #82 #83 #95
@petertheprocess petertheprocess self-assigned this Apr 26, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

This was linked to issues Apr 26, 2024
A user can see all rooms in Lobby page #1
Closed
A loggined user can go to profile page by clicking his avatar #28
Closed
A user can click avatar in his/her profile popup to change his/her avatar #65
Closed
@Haaaan1 Haaaan1 merged commit 0862e6b into main Apr 26, 2024
2 of 3 checks passed
@yixuan-zhou-uzh
Copy link
Contributor

yixuan-zhou-uzh commented Apr 26, 2024 •
edited
Loading

closes #38 #39 #46 #19 #7 #4 #3 #17 #106 #48 #32

This was linked to issues Apr 26, 2024
Implement the status-based set of gameroom layouts for different role of players #63
Closed
A player can listen to the shared audios from others after they confirm sharing #64
Closed
Implement the on-Receive function to deal with different messages from WebSocket #72
Closed
Implement the send function to form different messages to WebSocket #73
Closed
Implement a button disabled based on the status for users to quit the room. #82
Closed
Implement a start button disabled based on the status for the room owner to start the game. #83
Closed
Change ui and disabled conditions for buttons. #95
Closed
@yixuan-zhou-uzh yixuan-zhou-uzh removed a link to an issue Apr 26, 2024
A player can listen to the shared audios from others after they confirm sharing #64
Closed
@yixuan-zhou-uzh yixuan-zhou-uzh linked an issue Apr 26, 2024 that may be closed by this pull request
Implement a play button near the player div and a checkbox to indicate that the audio has been successfully uploaded and is available for other players to listen to. #7
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haaaan1 Haaaan1 Awaiting requested review from Haaaan1

@yixuan-zhou-uzh yixuan-zhou-uzh Awaiting requested review from yixuan-zhou-uzh

Assignees

@petertheprocess petertheprocess

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A user can click avatar in his/her profile popup to change his/her avatar Implement the status-based set of gameroom layouts for different role of players A loggined user can go to profile page by clicking his avatar Implement a play button near the player div and a checkbox to indicate that the audio has been successfully uploaded and is available for other players to listen to. A user can see all rooms in Lobby page
Implement the on-Receive function to deal with different messages from WebSocket Implement the send function to form different messages to WebSocket Implement a button disabled based on the status for users to quit the room. Implement a start button disabled based on the status for the room owner to start the game. Change ui and disabled conditions for buttons.
4 participants
@petertheprocess @yixuan-zhou-uzh @Haaaan1 @zihanltesla