Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] #111 - 로그인 화면전환 로딩 인디케이터 구현 및 릴리즈 전 마지막 수정작업 #112

Merged
merged 7 commits into from
Jan 13, 2023
Merged

[Fix] #111 - 로그인 화면전환 로딩 인디케이터 구현 및 릴리즈 전 마지막 수정작업 #112

merged 7 commits into from
Jan 13, 2023

Conversation

L-j-h-c
Copy link
Contributor

@L-j-h-c L-j-h-c commented Jan 12, 2023

🌴 PR 요약

🌱 작업한 브랜치

🌱 PR Point

  • 로그인 뷰 로딩 인디케이터 구현
  • 국가 및 displayName 수정
  • 미션 리스트 fetchType 기억하기

📮 관련 이슈

@L-j-h-c L-j-h-c added the Fix 문제 해결, 코드 수정 label Jan 12, 2023
@L-j-h-c L-j-h-c self-assigned this Jan 12, 2023
devxsby
devxsby approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@devxsby devxsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !! 🙇🏻‍♀️

lsj8706
lsj8706 approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!!

@L-j-h-c L-j-h-c merged commit d31866b into sopt-makers:develop Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devxsby devxsby devxsby approved these changes

@lsj8706 lsj8706 lsj8706 approved these changes

@yangsubinn yangsubinn Awaiting requested review from yangsubinn

Assignees

@L-j-h-c L-j-h-c

Labels
Fix 문제 해결, 코드 수정 size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 로그인 화면전환 로딩 인디케이터 구현
3 participants
@L-j-h-c @lsj8706 @devxsby