[Refactor] #144 - 로그인 로직 구현 및 회원가입, 비밀번호 변경 레거시 삭제 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsj8706
approved these changes
Apr 11, 2023
| @@ -23,3 +27,19 @@ public struct UserDefaultKeyList { | |||
| @UserDefaultWrapper<String>(key: "checkedAppVersion") public static var checkedAppVersion | |||
| } | |||
| } | |||
|
|
|||
| extension UserDefaultKeyList.Auth { | |||
| public static func getUserType() -> UserType { | |||
There was a problem hiding this comment.
사용자 타입 구분하는 함수 좋네요!! 유용하게 쓰일 것 같아요!!
| func checkNickname(nickname: String) | ||
| func resetEmailValidation() |
Comment on lines
94
to
98
| private enum Metric { | ||
| static let topInset = 151.adjustedH + logoMutableY | ||
| static let logoWidth = 184.adjusted | ||
| static let logoMutableY = 137.adjustedH | ||
| static let logoRatio = 114 / 184 |
There was a problem hiding this comment.
궁금한 것이 있어요!
간격 수치를 이렇게 구조화해서 사용하는 방식이 확실히 좋은데 혹시 static 변수로 만들면 전역적으로 메모리에 위치하여 메모리 낭비가 발생하지는 않을까요...?
There was a problem hiding this comment.
저도 고것이 궁금했었는데요ㅕ
어디선가 벤치마킹을 해보니 별 의미 없는 수치였다고 걱정말고 사용하라고 들었슴당...!
| } | ||
| } | ||
|
|
||
| private func showAnimation() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 PR Point
남은 작업
📮 관련 이슈