Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] #144 - UserID -> AccessToken 이전 작업 & API 변경사항 반영 #148

Merged
merged 3 commits into from
Apr 11, 2023
Merged

[Refactor] #144 - UserID -> AccessToken 이전 작업 & API 변경사항 반영 #148

merged 3 commits into from
Apr 11, 2023

Conversation

L-j-h-c
Copy link
Contributor

@L-j-h-c L-j-h-c commented Apr 11, 2023

🌴 PR 요약

🌱 작업한 브랜치

📌 참고 사항

  • UserID -> AccessToken으로 이전 작업 진행했습니다. 현재 static하게 토큰을 넣어뒀는데 곧 만료될거라 괜찮(?)을거에요...
  • 아래 API들의 변경사항(탈퇴 제외)을 모두 적용했습니다. 모두 잘 동작하는 것 확인했습니다.

image

- Main View에 임시로 설정 및 로그인 뷰에 진입점을 생성해 두었습니다...! 나중에 삭제하면 될 것 같아요~

남은 작업

  • I18N 스트링 중 쓰이지 않는 것들 삭제

📮 관련 이슈

@L-j-h-c L-j-h-c requested a review from a team April 11, 2023 14:46
@L-j-h-c L-j-h-c self-assigned this Apr 11, 2023
@L-j-h-c L-j-h-c requested review from elesahich, 0inn, lsj8706 and devxsby and removed request for a team April 11, 2023 14:46
lsj8706
lsj8706 approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

바뀐 부분이 꽤 있던데 빠르게 반영하셨네요 대박!!
감사합니다~!!!!

elesahich
elesahich approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@elesahich elesahich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 감사합니다 준호 👍🚀

@L-j-h-c L-j-h-c merged commit 58a9a85 into sopt-makers:develop Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsj8706 lsj8706 lsj8706 approved these changes

@elesahich elesahich elesahich approved these changes

@0inn 0inn Awaiting requested review from 0inn 0inn was automatically assigned from sopt-makers/ios-chapter-2nd

@devxsby devxsby Awaiting requested review from devxsby devxsby was automatically assigned from sopt-makers/ios-chapter-2nd

Assignees

@L-j-h-c L-j-h-c

Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactor] 새로운 버전 API 대응
3 participants
@L-j-h-c @elesahich @lsj8706