[Feat] #151 - 메인 뷰 및 팝업 뷰 UI수정 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-j-h-c
approved these changes
Apr 15, 2023
| title: String, | ||
| description: String, | ||
| customButtonTitle: String, | ||
| customAction: (() -> Void)?) -> AlertViewControllable | ||
| func makeNetworkAlertVC() -> AlertViewControllable | ||
| func makeNetworkAlertVC(theme: AlertVC.AlertTheme) -> AlertViewControllable |
| @@ -21,7 +21,7 @@ final class UserHistoryHeaderView: UICollectionReusableView { | |||
| label.font = UIFont.Main.display2 | |||
| label.numberOfLines = 2 | |||
| label.textAlignment = .left | |||
| label.text = "OOO님은\nSOPT와 D+1234일째" | |||
| label.text = "OOO님은\nSOPT와 N개월째" | |||
There was a problem hiding this comment.
알고계시겠지만, 추후에 API가 연결되면
I18N에서 static func을 이용하여 000과 N을 전달 가능합니다!
Comment on lines
60
to
71
| let attributedText = NSMutableAttributedString(string: text, | ||
| attributes: [ | ||
| .foregroundColor: DSKitAsset.Colors.white100.color, | ||
| .font: UIFont.Main.display2 | ||
| ]) | ||
| attributedText.addAttribute(.font, | ||
| value: UIFont.Main.display1, | ||
| range: (text as NSString).range(of:"\(name)")) | ||
|
|
||
| attributedText.addAttribute(.font, | ||
| value: UIFont.Main.display1, | ||
| range: (text as NSString).range(of:"안녕하세요")) |
There was a problem hiding this comment.
요 부분은 함수로 분리해서 재사용 할 수도 있을 것 같아요~
There was a problem hiding this comment.
이 부분 코드가 너무 길어졌네요! 바로 함수로 분리했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 PR Point
📌 참고 사항
📸 스크린샷
📮 관련 이슈