Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #167 - 출석 점수 조회하기 서버 수정 #172

Merged
merged 4 commits into from
Apr 17, 2023
Merged

[Feat] #167 - 출석 점수 조회하기 서버 수정 #172

merged 4 commits into from
Apr 17, 2023

Conversation

0inn
Copy link
Contributor

@0inn 0inn commented Apr 17, 2023 •
edited
Loading

🌴 PR 요약

🌱 작업한 브랜치

🌱 PR Point

📌 참고 사항

  • Entity가 달라서 수정했습니다.
    success, message, data 가지는 BaseEntity 일단 추가해뒀습니다 . . !
  • 스크롤 영역 safeArea에서 전체로 수정했습니다.
  • 실서버 수정여부는 답변 받은 후에 바로 공유하겠습니다 ~

(급하게 PR 날려서 이미지 에셋이 추가되었습니다 . 하하.)

📸 스크린샷

기능 스크린샷
기능이름 스크린샷 첨부

📮 관련 이슈

@0inn 0inn added Fix 문제 해결, 코드 수정 영인☁️ labels Apr 17, 2023
@0inn 0inn self-assigned this Apr 17, 2023
devxsby
devxsby approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@devxsby devxsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다 ! 쵝 오 🦕

lsj8706
lsj8706 approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!

SOPT-iOS/Projects/Modules/Network/Sources/Foundation/BaseEntity.swift
import Foundation

public struct BaseEntity<T: Decodable>: Decodable {
let success: Bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 친구들은 public 필요 없을까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

필요할 것 같아요 . .!
추후에 수정해두겠습니다 !

@0inn 0inn merged commit a823cf5 into sopt-makers:develop Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devxsby devxsby devxsby approved these changes

@lsj8706 lsj8706 lsj8706 approved these changes

@elesahich elesahich Awaiting requested review from elesahich

@L-j-h-c L-j-h-c Awaiting requested review from L-j-h-c

Assignees

@0inn 0inn

Labels
Fix 문제 해결, 코드 수정 size/L 영인☁️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] 출석 점수 조회하기 서버 수정
3 participants
@0inn @lsj8706 @devxsby