Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #14 - 미션 리스트 UI 구현 #26

Merged
merged 10 commits into from
Dec 4, 2022
Merged

[Feat] #14 - 미션 리스트 UI 구현 #26

merged 10 commits into from
Dec 4, 2022

Conversation

L-j-h-c
Copy link
Contributor

@L-j-h-c L-j-h-c commented Dec 3, 2022

🌴 PR 요약

🌱 작업한 브랜치

🌱 PR Point

미션 리스트 UI 구현했습니다. 마음에 들지 않는 부분이 좀 있지만 여유가 없어서 일단 올립니다..!
공용 컴포넌트도 있고 해서 일단 올리고 작업 이어나가겠습니다.

📌 참고 사항

StarView를 구현했습니다! 생성자에 spacing, scale, level 입력하시면 됩니다!

📸 영상

KakaoTalk_Video_2022-12-04-04-16-38.mp4

📮 관련 이슈

@L-j-h-c L-j-h-c added Feat 새로운 기능 구현 준호🏅 labels Dec 3, 2022
@L-j-h-c L-j-h-c self-assigned this Dec 3, 2022
yangsubinn
yangsubinn approved these changes Dec 4, 2022
View reviewed changes
Copy link
Member

@yangsubinn yangsubinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

starView 잘 쓰겠습니다 머지 해주세욜 .. 🙇‍♀️

@L-j-h-c L-j-h-c merged commit c25ad0d into sopt-makers:develop Dec 4, 2022
devxsby
devxsby reviewed Dec 4, 2022
View reviewed changes
Copy link
Member

@devxsby devxsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 굉장히 빠른 작업 . . .
고생하셨습니당 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devxsby devxsby devxsby left review comments

@yangsubinn yangsubinn yangsubinn approved these changes

@lsj8706 lsj8706 Awaiting requested review from lsj8706

Assignees

@L-j-h-c L-j-h-c

Labels
Feat 새로운 기능 구현 size/XL 준호🏅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 미션 리스트 뷰 구현
3 participants
@L-j-h-c @devxsby @yangsubinn