[Feature] Poke-Notification 뷰 구현, 데이터 연결 완료 #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0inn
approved these changes
Dec 23, 2023
lsj8706
approved these changes
Dec 23, 2023
|
|
||
| self.userId = try container.decode(Int.self, forKey: .userId) | ||
| self.playgroundId = try container.decode(Int.self, forKey: .playgroundId) | ||
| self.profileImage = try container.decodeIfPresent(String.self, forKey: .profileImage) ?? "" |
There was a problem hiding this comment.
이렇게 바꾼건 API Response에서 profileImage가 nil일 때 디코딩 fail이 발생하는 것을 방지하기 위한 것일까요?
There was a problem hiding this comment.
네 마자요 하나의 디코딩만 실패하도록 하는거에요~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
Poke-Notification 뷰 구현, 데이터 연결 완료하는 PR이에요 ~ #332 위에 쌓은거라서 332가 먼저 머지되어야 해요
🌱 작업한 브랜치
🌱 PR Point
TODO
DONE
📌 참고 사항
📸 스크린샷
📮 관련 이슈