Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] #416 - PokeOnboarding 새로고침 시 Push 계속 되는 현상 수정 #417

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

dlwogus0128
Copy link
Contributor

@dlwogus0128 dlwogus0128 commented Oct 22, 2024

🌴 PR 요약

🌱 작업한 브랜치

🌱 PR Point

  • PokeOnboarding에서 pull to refresh를 진행할 때마다, 이어서 push되는 SoptWebView의 push 개수가 하나씩 증가되는 버그를 해결했습니다.
    • collection view cell을 reuse할 때 구독이 중복되어 발생하는 문제였습니다.
    • 따라서 prepareForReuse에서 cell의 cancelBag을 초기화하여 기존 구독을 취소하고, 새로운 구독을 생성하도록 처리했습니다. 기존에는 vc의 생명주기 동안 구독이 유지되었는데, 이렇게 해서 cell의 생명주기에 맞추어 구독을 초기화 해줄 수 있습니다...!!

📌 참고 사항

pr 올리는 김에... Manifests에서 DailySoptuneFeature -> PokeFeatureInterface 의존성 같이 추가해줬습니다..^.^

let project = Project.makeModule(
    name: "DailySoptuneFeature",
    targets: [.unitTest, .staticFramework, .demo, .interface],
    internalDependencies: [
        .Features.Poke.Interface
    ],
    interfaceDependencies: [
        .Features.BaseFeatureDependency
    ]
)

📸 스크린샷

기능 스크린샷
AS-IS
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-21.at.22.24.22.mp4
TO-BE
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-22.at.10.33.12.mp4

📮 관련 이슈

@dlwogus0128 dlwogus0128 added Fix 문제 해결, 코드 수정 재현✦ labels Oct 22, 2024
@dlwogus0128 dlwogus0128 requested a review from yungu0010 October 22, 2024 01:53
@dlwogus0128 dlwogus0128 self-assigned this Oct 22, 2024
Copy link

height bot commented Oct 22, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Contributor

@yungu0010 yungu0010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

버그 발견한 것도 최고,, 고친 것도 최고 ,, 감사합니당!


public override func prepareForReuse() {
super.prepareForReuse()
self.cancelBag = CancelBag()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉 여기서 초기화를 해주어야 하는군요 !_!

@dlwogus0128 dlwogus0128 merged commit 35686dc into develop Oct 22, 2024
@dlwogus0128 dlwogus0128 deleted the fix/#416-pokeonboarding-refresh-push-bug branch October 22, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix 문제 해결, 코드 수정 size/XS 재현✦
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] PokeOnboarding 새로고침 시 Push 계속 되는 현상 수정
2 participants