Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] #428 - 솝탬프 수정 오류 #429

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

yungu0010
Copy link
Contributor

@yungu0010 yungu0010 commented Oct 29, 2024

🌴 PR 요약

🌱 작업한 브랜치

🌱 PR Point

  • 솝탬프 수정 오류 반영했습니다! @dlwogus0128 감사합니다🫶

문제 원인

  1. ListDetailViewModel에서 uploadUrl을 옵셔널 프로퍼티로 가지고 있음.
  2. DetailVC로 진입할 때 솝탬프 정보를 fetch해오는 과정에서 uploadUrl을 지정해주지 않음
listDetailModel.asDriver()
    .compactMap {
        self.stampId = $0.stampId
        return $0
}
  1. 수정 완료 버튼을 눌렀을 때 self의 uploadUrl이 nil이라 데이터 흐름이 전달되지 않음
input.bottomButtonTapped
      .eraseToAnyPublisher()
      .flatMap { [weak self] requestModel -> Driver<ListDetailRequestModel> in
        guard
          let self,
          let presignedUrl = self.uploadedUrl?.removePercentEncodingIfNeeded()    // crash 발생 ‼️
        else { return .empty() }

문제 해결

  • @dlwogus0128이 도움주신대로 처음 값을 fetch해올 때 self.uploadUrl을 지정해주었습니다.

📌 참고 사항

  • release에 머지해서 2.6.1로 업데이트 하겠습니다 !
  • 해당 PR 내용은 develop 작업할 때 같이 추가하면 되겠죠 .. ?

📮 관련 이슈

@yungu0010 yungu0010 added Fix 문제 해결, 코드 수정 윤서🍉 labels Oct 29, 2024
@yungu0010 yungu0010 self-assigned this Oct 29, 2024
@yungu0010 yungu0010 linked an issue Oct 29, 2024 that may be closed by this pull request
1 task
@yungu0010 yungu0010 merged commit b4fa968 into release Oct 29, 2024
@yungu0010 yungu0010 deleted the hotfix/#428-soptampEditFix branch October 29, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix 문제 해결, 코드 수정 size/XS 윤서🍉
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Hotfix] 솝탬프 수정 오류
1 participant