[Feat] #28 - 미션 리스트 뷰 비즈니스 로직 구현 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangsubinn
approved these changes
Dec 21, 2022
| public let id: Int | ||
| public let title: String | ||
| public let level: Int | ||
| public let profileImage: [String]? |
There was a problem hiding this comment.
아 이거 서버쪽에서 뺀다구 전달받았는디 아직 결과값에 일부 들어오고 있나보네여...
Comment on lines
+54
to
+57
| public enum HeaderType { | ||
| case json | ||
| case jsonUserId(userId: Int) | ||
| case userId(userId: Int) |
Comment on lines
+107
to
+109
| func toListDetailSceneType() -> ListDetailSceneType { | ||
| return (self.isCompleted == true) ? .edit : .none | ||
| } |
…feature/sopt-makers#28-MissionListBusiness # Conflicts: # SOPT-Stamp-iOS/Projects/Modules/Network/Sources/Foundation/BaseAPI.swift # SOPT-Stamp-iOS/Projects/SOPT-Stamp-iOS/Sources/Application/SceneDelegate.swift
lsj8706
approved these changes
Dec 23, 2022
| case levelOne | ||
| case levelTwo | ||
| case levelThree | ||
| public enum StarViewLevel: Int { |
| } | ||
| } | ||
|
|
||
| extension MissionListRepository: MissionListRepositoryInterface { | ||
|
|
||
| public func fetchMissionList(type: MissionListFetchType, userId: Int?) -> AnyPublisher<[MissionListModel], Error> { | ||
| let userId: Int = (userId != nil) |
There was a problem hiding this comment.
let userId = userId ?? 1 과 같은 의미인가요..?
There was a problem hiding this comment.
@lsj8706 그렇네요 엘비스 연산자가 쓰기 싫어서 그래왔는데 그냥 쓰는것도 좋아 보이는군요...
devxsby
approved these changes
Dec 23, 2022
| @@ -26,7 +27,9 @@ public class MissionListVC: UIViewController { | |||
| } | |||
| private var cancelBag = CancelBag() | |||
|
|
|||
| lazy var dataSource: UICollectionViewDiffableDataSource<MissionListSection, AnyHashable>! = nil | |||
| private var missionTypeMenuSelected = CurrentValueSubject<MissionListFetchType, Error>(.all) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 PR Point
미션 리스트 뷰 API 및 비즈니스 로직 구현했습니다.
네트워크 베이스를 조금 수정했습니다. header에 특이하게 UserId가 들어가기 때문에 해당 부분 열거형을 추가했습니다.
미션 디테일 뷰 및 랭킹 뷰, 랭킹 미션 리스트로의 전환 로직을 구현했습니다.
코드 개선을 위한 피드백 언제나 환영입니다!
📮 관련 이슈