Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #60 - 계정 찾기 뷰 구현 #70

Merged
merged 7 commits into from
Jan 1, 2023
Merged

[Feat] #60 - 계정 찾기 뷰 구현 #70

merged 7 commits into from
Jan 1, 2023

Conversation

devxsby
Copy link
Member

@devxsby devxsby commented Jan 1, 2023

🌴 PR 요약

🌱 작업한 브랜치

🌱 PR Point

  • 로그인 뷰에서 연결되는 계정 찾기 뷰 레이아웃을 만들고 버튼 클릭시 구글폼 링크로 연결해놓았어요.

📌 참고 사항

  • I18N처럼 구글폼 링크 등 URL만 따로 관리하는거를 빼고 싶은데 어디에 놓으면 좋을까요?

📸 스크린샷

계정찾기 뷰 버튼 클릭시 사파리 연결
Simulator Screen Shot - iPhone 13 mini - 2023-01-01 at 21 38 16 Simulator Screen Shot - iPhone 13 mini - 2023-01-01 at 21 38 22

📮 관련 이슈

@devxsby devxsby added Feat 새로운 기능 구현 윤수🥚 labels Jan 1, 2023
@devxsby devxsby self-assigned this Jan 1, 2023
lsj8706
lsj8706 approved these changes Jan 1, 2023
View reviewed changes
Copy link
Member

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!

yangsubinn
yangsubinn approved these changes Jan 1, 2023
View reviewed changes
Copy link
Member

@yangsubinn yangsubinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨씀니다 ✨
url은 Core의 literals 안에 URL용으로 따로 파일 하나 만들어서 보관해두 될 것 같아여 !

@devxsby devxsby merged commit ec62d5e into sopt-makers:develop Jan 1, 2023
@devxsby devxsby deleted the feat/#60-계정찾기뷰 branch January 1, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangsubinn yangsubinn yangsubinn approved these changes

@lsj8706 lsj8706 lsj8706 approved these changes

@L-j-h-c L-j-h-c Awaiting requested review from L-j-h-c

Assignees

@devxsby devxsby

Labels
Feat 새로운 기능 구현 size/L 윤수🥚
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 계정 찾기 뷰 구현 및 외부 브라우저 연결
3 participants
@devxsby @lsj8706 @yangsubinn