Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] #78 - Network 모듈에 Domain 의존성 제거 및 userId 추가 #79

Merged
merged 1 commit into from
Jan 4, 2023
Merged

[Fix] #78 - Network 모듈에 Domain 의존성 제거 및 userId 추가 #79

merged 1 commit into from
Jan 4, 2023

Conversation

yangsubinn
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 PR Point

  • Network 모듈에 import Domain 제거
  • ListDetailRequestModel이 아닌 [Any] 사용
  • 불필요한 Sample 파일 삭제
  • userId 연결

📌 참고 사항

📸 스크린샷

기능 스크린샷
기능이름 스크린샷 첨부

📮 관련 이슈

@yangsubinn yangsubinn added Fix 문제 해결, 코드 수정 양수🌷 labels Jan 4, 2023
@yangsubinn yangsubinn self-assigned this Jan 4, 2023
L-j-h-c
L-j-h-c approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@yangsubinn yangsubinn merged commit 63d4e49 into sopt-makers:develop Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-j-h-c L-j-h-c L-j-h-c approved these changes

@lsj8706 lsj8706 Awaiting requested review from lsj8706

@devxsby devxsby Awaiting requested review from devxsby

Assignees

@yangsubinn yangsubinn

Labels
Fix 문제 해결, 코드 수정 size/M 양수🌷
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] Network 레이어에서 Domain 의존성 제거
2 participants
@yangsubinn @L-j-h-c