Fix/order book improvements #1347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustemYuzlibaev
requested review from
Sociopacific,
stefashkaa and
Nikita-Polyakov
RustemYuzlibaev
added
the
experimental_environment
stefashkaa
reviewed
Mar 26, 2024
stefashkaa
reviewed
Mar 26, 2024
stefashkaa
reviewed
Mar 26, 2024
| @@ -87,14 +87,15 @@ | |||
| </div> | |||
|
|
|||
| <div v-if="withSlider" class="input-line--footer-with-slider" @click="handleSliderFocus"> | |||
| <div class="delimiter" /> | |||
There was a problem hiding this comment.
I think that it's better to just revert it without !important. What was the initial goal of that change?
There was a problem hiding this comment.
we have < s-divider /> component to split UI data, no need to create another custom one
stefashkaa
reviewed
Mar 26, 2024
stefashkaa
reviewed
Mar 26, 2024
| @@ -341,7 +349,7 @@ $el-input-class: '.el-input'; | |||
| .el-slider__button { | |||
| background-color: #fff; | |||
| border-radius: 4px; | |||
| transform: rotate(-45deg); | |||
| transform: rotate(-45deg) !important; | |||
There was a problem hiding this comment.
better to replace scoped to unscoped without !important + specify better
stefashkaa
reviewed
Mar 26, 2024
| // overwrite | ||
| .el-slider__runway.disabled { | ||
| .el-slider__bar { | ||
| width: 0 !important; |
There was a problem hiding this comment.
the same comment - if we need to apply anything we cannot do it scoped scss then we need to replace it
…kaswap-exchange-web into fix/order-book-improvements
stefashkaa
removed
the
experimental_environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contains fixes on these tickets
