Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bridge signer pallet #85

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add bridge signer pallet #85

wants to merge 2 commits into from

Conversation

vovac12
Copy link
Contributor

@vovac12 vovac12 commented Sep 17, 2024

No description provided.

@vovac12 vovac12 requested a review from N1ghtStorm September 17, 2024 07:54

pub fn public(&self) -> MultiSigner {
match self {
Self::Ecdsa(pub_key, _) => MultiSigner::Ecdsa(pub_key.clone()),

Check failure

Code scanning / clippy

using clone on type Public which implements the Copy trait Error

using clone on type Public which implements the Copy trait

pub fn public(&self) -> MultiSigner {
match self {
Self::Ecdsa(pub_key, _) => MultiSigner::Ecdsa(pub_key.clone()),

Check failure

Code scanning / clippy

using clone on type Public which implements the Copy trait Error

using clone on type Public which implements the Copy trait
pub fn public(&self) -> MultiSigner {
match self {
Self::Ecdsa(pub_key, _) => MultiSigner::Ecdsa(pub_key.clone()),
Self::Ed25519(pub_key, _) => MultiSigner::Ed25519(pub_key.clone()),

Check failure

Code scanning / clippy

using clone on type Public which implements the Copy trait Error

using clone on type Public which implements the Copy trait
pub fn public(&self) -> MultiSigner {
match self {
Self::Ecdsa(pub_key, _) => MultiSigner::Ecdsa(pub_key.clone()),
Self::Ed25519(pub_key, _) => MultiSigner::Ed25519(pub_key.clone()),

Check failure

Code scanning / clippy

using clone on type Public which implements the Copy trait Error

using clone on type Public which implements the Copy trait
match self {
MultiSignatures::Ecdsa(sigs) => sigs
.iter()
.map(|(pk, sig)| MultiSignature::Ecdsa(pk.clone(), sig.clone()))

Check failure

Code scanning / clippy

using clone on type Public which implements the Copy trait Error

using clone on type Public which implements the Copy trait
pub fn add_peer(&mut self, pub_key: MultiSigner) -> bool {
match (self, pub_key) {
(Self::Ecdsa(pub_keys), MultiSigner::Ecdsa(pub_key)) => {
return pub_keys.try_insert(pub_key).unwrap_or(false);

Check failure

Code scanning / clippy

unneeded return statement Error

unneeded return statement
return pub_keys.try_insert(pub_key).unwrap_or(false);
}
(Self::Ed25519(pub_keys), MultiSigner::Ed25519(pub_key)) => {
return pub_keys.try_insert(pub_key).unwrap_or(false);

Check failure

Code scanning / clippy

unneeded return statement Error

unneeded return statement
return pub_keys.try_insert(pub_key).unwrap_or(false);
}
(Self::Ed25519(pub_keys), MultiSigner::Ed25519(pub_key)) => {
return pub_keys.try_insert(pub_key).unwrap_or(false);

Check failure

Code scanning / clippy

unneeded return statement Error

unneeded return statement
(Self::Ed25519(pub_keys), MultiSigner::Ed25519(pub_key)) => {
return pub_keys.try_insert(pub_key).unwrap_or(false);
}
_ => return false,

Check failure

Code scanning / clippy

unneeded return statement Error

unneeded return statement
(Self::Ed25519(pub_keys), MultiSigner::Ed25519(pub_key)) => {
return pub_keys.try_insert(pub_key).unwrap_or(false);
}
_ => return false,

Check failure

Code scanning / clippy

unneeded return statement Error

unneeded return statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant