Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --autoMerge and --autoMergeMethod #248

Merged
merged 5 commits into from
Feb 12, 2021

Conversation

brianseeders
Copy link
Contributor

@brianseeders
Copy link
Contributor Author

@sqren I did implement a enablePullRequestAutoMerge.private.test.ts pointed to my fork for testing, but didn't commit it. I wasn't sure how you would want to handle.

@sorenlouv
Copy link
Owner

I did implement a enablePullRequestAutoMerge.private.test.ts pointed to my fork for testing, but didn't commit it. I wasn't sure how you would want to handle.

Awesome! Can you commit it and I'll create a repo under https://github.com/backport-org.
Btw. lmk if you have better ideas for these types of e2e tests. I've found them super valuable and easy to write but it seems a bit fishy that I have to create the repo like in this case.

@brianseeders
Copy link
Contributor Author

brianseeders commented Feb 10, 2021 via email

@sorenlouv
Copy link
Owner

For example, it needs to make sure that the option gets disabled after each test

Ah, true!

@brianseeders
Copy link
Contributor Author

@sqren I added enablePullRequestAutoMerge.private.test.ts. The tests are currently gated until the TEST_* constants at the top are filled in.

lmk if you have better ideas for these types of e2e tests.

When you're writing something that's whole purpose is to integrate with a thing, and you can't run your own version of that thing, this is pretty much all you can do for e2e tests. It's super easy to just say "it's not worth it" and not do e2e tests at all, so good on you for setting them up!

@sorenlouv sorenlouv merged commit fc71c57 into sorenlouv:master Feb 12, 2021
@sorenlouv
Copy link
Owner

Released in v5.6.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants