history-substring-search should use zstyle

[sorin-ionescu]

Since history-substring-search has diverged a little bit from upstream, we might as well convert it fully.

[meh]

Umh, can we at least have a way to set the colors from ~/.zpreztorc?

If you set HISTORY_SUBSTRING_SEARCH_HIGHLIGHT_{FOUND,NOT_FOUND} in ~/.zshenv or ~/.zpreztorc it gets overwritten and putting it in ~/.zshrc looks very bad to me.

[ColinHebert]

I guess it would be easy to add a few zstyles to set the colors on {FOUND,NOT_FOUND}.

[lucy]

I think you should set it in ~/.zshrc, since AFAIK both ~/.zshenv and ~/.zpreztorc are sourced before the module is loaded.

[meh]

I think you should set it in ~.zshrc, since AFAIK both ~/.zshenv and ~/.zpreztorc are sourced before the module is loaded.

That's why I'm asking to add a zstyle to set the colors, to keep it
consistent.

[ColinHebert]

@neeee Yeah, but everything that is loaded in prezto should be configurable in zpreztorc

[sorin-ionescu]

I would leave it alone since syntax highlighting is so buggy.

[meh]

It's included as module, it's two lines of code to do the setting from the zstyle.

It works perfectly here except for this configuration issue, what's the point of including it if you don't even make it configurable properly?

You keep forgetting this is a community project and not your little personal configuration thing and should be a bit more open minded about it.

If this is not supposed to be a community project just say it clearly so I can get out of here and do something myself.

[sorin-ionescu]

Are you still on medication? Your attitude still sucks.

Community does not mean that you scream and whine at me until a change is done in your favour. It means that you do it yourself. So, open a pull request. Then, I'll have a look at it.

[meh]

Are you still on medication? Your attitude still sucks.

Sure. You should too, your attitude sucks as well.

Community does not mean that you scream and whine at me until a change is done in your favour. It means that you do it yourself. So, open a pull request. Then, I'll have a look at it.

There's a difference between saying "you can do it" and "leave it
alone".

And the former surely isn't what you said.

I asked to have it done because it's two lines that are easier for you
to write than for me to open a pull request and have you whine at the
style and whatnot until you accept it and rewrite it all as you like
it.

Thought skipping the pointless steps would be better for two lines.

[sorin-ionescu]

I could easily follow the following protocol: If the pull requester can't be bothered to read the contribution rules, and the source code to get a feel for the style, I can't be bothered to read the pull request.

I could just close pull requests that don't conform to the project. Instead, I give people an opportunity to fix them.

If you want an everything goes crap fest, use Oh My Zsh.

Yet, you don't.

You can't have it both ways.

So open your pull request, or forever hold your silence.

[sorin-ionescu]

Is something like a833a9a what you wanted?