Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update gSu #1929

Closed
wants to merge 2 commits into from
Closed

update gSu #1929

wants to merge 2 commits into from

Conversation

hidekuro
Copy link
Contributor

Proposed Changes

Remove origin master from gSu.
It safe for branches not named "master".

  • Avoid the error "fatal: couldn't find remote ref master" in a repository which the default branch is not "master".
  • And with this method, we can add any remote and branch name after it such as "origin master" or "upstream main".

@hidekuro
update gSu
afb466c 
Safe for branches not named "master".

And with this method, we can add any remote and branch name after it such as "origin master" or "upstream main".
@indrajitr
Copy link
Collaborator

Does it help if you do: git submodule update --recursive --remote in your case?
Admittedly, it might not work if the submodule branch isn't set properly though.

@hidekuro
Copy link
Contributor Author

@indrajitr It seems better. It works fine in my case. :)
I will change to the method you suggested.

@hidekuro
improve gSu
b3b7e0f 
Change method to `update` instead of `foreach`.
@indrajitr indrajitr mentioned this pull request May 17, 2021
Merged
@indrajitr
Copy link
Collaborator

indrajitr commented May 17, 2021 •
edited
Loading

Thank you @hidekuro! Your changes have been cherry-picked (with additional comments) in #1930.

@hidekuro
Copy link
Contributor Author

The proposal has been cherry-picked into #1930, so I close this PR.

@hidekuro hidekuro closed this May 18, 2021
@hidekuro hidekuro deleted the patch-1 branch May 18, 2021 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hidekuro @indrajitr