-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for docker and boot2docker #863
Conversation
# | ||
|
||
# Only setup the boot2docker commands and aliases if we're on OSX | ||
if [[ "$OSTYPE" == darwin* ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other operating systems don't need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linux boxes dont since they can run docker natively (don't need the virtualization layer that boot2docker provides). Windows likely needs it, but I only have access to windows VMs so I can't test a vm within a vm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are native Mac and Windows clients in beta. They still use a VM behind the scenes, but once these clients leave beta, boot2docker will basically be out of a job.
The completions aren't mine, they're out of the docker project (I did check the license before I sent the pull request). I'll see if I can get the two teams to talk to each other. |
Docker (at least when installed via the boot2docker keg) comes with a bash completion script. I can search for and autoload that if found. Not sure of the best way to find it if not installed via homebrew. Thoughts? |
BASH and Zsh completions are not compatible.
|
@skarfacegc will you work on this PR? If you have no time I can merge it with mine and send. If you don't mind of course |
The only thing blocking it is having the completions added to the zsh-completions repo. I've contacted them and have heard nothing back. |
As I understood this PR needs to be cleared up from completion code and everything else is ok. |
https://github.com/zsh-users/zsh-completions/blob/master/src/_docker Docker completions appears to have been merged in towards the beginning of June with this commit: zsh-users/zsh-completions@73b3d62 Is anything else required? |
@kusold Who was that question directed at? You should tag them. |
Sorry, I've been crushed with work. I'll get the PR updated to use the docker completions in zsh-completions. |
switched to docker-machine and removed completions |
I've got a few more things I want to add to this. more docker-machine aliases and automatically attaching to the first running docker-machine instance |
FYI: https://github.com/felixr/docker-zsh-completion has instructions for integrating with Prezto / completions module. Although looks like Docker now has built-in ZSH autocompletions... |
There was some major work in #1147 to get a bunch of docker aliases in. I'm not sure if there are any aliases here that weren't in the other PR, but feel free to open another with those changes if you want them. Thanks for taking the time to submit this! |
Add some commands to reduce typing when using boot2docker (setting up the correct environmental variables correctly etc).
Add completion for docker commands