Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed listen address in SUReplAccessStrict #520

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

t0k4rt
Copy link

@t0k4rt t0k4rt commented Jun 19, 2018

Hello,
I was deploying our stolon cluster when I spotted an issue with SUReplAccessStrict mode,
The hba generated get the master listen address instead of the standby address.
This should work as expected with this fix.

@sgotti
Copy link
Member

sgotti commented Jun 19, 2018

@t0k4rt Thanks for the PR. I'm on vacation so I'll be able to review it at the start of July.

I noticed that in #412 I proposed some tests for generateHBA but they weren't pulled in that PR.

Can you please fetch that test (sgotti@cfc5a03#diff-b0ec7cb5ed37c927cafbf2e430672a47R82%60 and fix/update it to also catch this case (if not already catching it)? The test without this patch should fail while with this patch it should pass.

@t0k4rt
Copy link
Author

t0k4rt commented Jun 19, 2018

Thanks for your time :-)
I'll check the test !

@sgotti
Copy link
Member

sgotti commented Jul 2, 2018

@t0k4rt I updated your commit with the tests, see here: sgotti@3d0d3ca

Can you check/test it and if it's right update this PR with that commit? If you don't have time I'll do it in the next days creating a new PR. Thanks.

@sgotti
Copy link
Member

sgotti commented Jul 2, 2018

@t0k4rt You should just cherry pick only commit sgotti@3d0d3ca and remove the other commits.

@t0k4rt t0k4rt force-pushed the feature-su-repl-access-mode branch from e788499 to 79216fb Compare July 2, 2018 14:01
@t0k4rt
Copy link
Author

t0k4rt commented Jul 2, 2018

ok I'm working on it

@t0k4rt t0k4rt force-pushed the feature-su-repl-access-mode branch from 79216fb to 5b9773f Compare July 2, 2018 14:06
@t0k4rt
Copy link
Author

t0k4rt commented Jul 2, 2018

Should be okay now

@sgotti
Copy link
Member

sgotti commented Jul 3, 2018

@t0k4rt Can you please use only the commit sgotti@3d0d3ca that already has everything (the fix and a good commit message)?

@t0k4rt
Copy link
Author

t0k4rt commented Jul 3, 2018

this is what I did:
I prepared a clean branch with the fix only
Then I did:
git cherry-pick 3d0d3ca
Then I pushed.
If I must do something else, please tell me.

@sgotti
Copy link
Member

sgotti commented Jul 3, 2018

@t0k4rt in that way you have two commits. To only use sgotti@3d0d3ca just do

git reset --hard origin/master
git cherry-pick 3d0d3ca

Also add tests got generateHBA func.
@t0k4rt t0k4rt force-pushed the feature-su-repl-access-mode branch from 5b9773f to cd3025e Compare July 3, 2018 09:30
@t0k4rt
Copy link
Author

t0k4rt commented Jul 3, 2018

Ok done

@sgotti
Copy link
Member

sgotti commented Jul 3, 2018

@t0k4rt Thanks! LGTM. Merging

@sgotti sgotti merged commit cd3025e into sorintlab:master Jul 3, 2018
sgotti added a commit that referenced this pull request Jul 3, 2018
fixed listen address in SUReplAccessStrict
@sgotti sgotti added this to the v0.12.0 milestone Jul 3, 2018
@t0k4rt
Copy link
Author

t0k4rt commented Jul 4, 2018

Thanks to you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants