-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed listen address in SUReplAccessStrict #520
Conversation
@t0k4rt Thanks for the PR. I'm on vacation so I'll be able to review it at the start of July. I noticed that in #412 I proposed some tests for Can you please fetch that test (sgotti@cfc5a03#diff-b0ec7cb5ed37c927cafbf2e430672a47R82%60 and fix/update it to also catch this case (if not already catching it)? The test without this patch should fail while with this patch it should pass. |
Thanks for your time :-) |
@t0k4rt I updated your commit with the tests, see here: sgotti@3d0d3ca Can you check/test it and if it's right update this PR with that commit? If you don't have time I'll do it in the next days creating a new PR. Thanks. |
@t0k4rt You should just cherry pick only commit sgotti@3d0d3ca and remove the other commits. |
e788499
to
79216fb
Compare
ok I'm working on it |
79216fb
to
5b9773f
Compare
Should be okay now |
@t0k4rt Can you please use only the commit sgotti@3d0d3ca that already has everything (the fix and a good commit message)? |
this is what I did: |
@t0k4rt in that way you have two commits. To only use sgotti@3d0d3ca just do
|
Also add tests got generateHBA func.
5b9773f
to
cd3025e
Compare
Ok done |
@t0k4rt Thanks! LGTM. Merging |
fixed listen address in SUReplAccessStrict
Thanks to you :-) |
Hello,
I was deploying our stolon cluster when I spotted an issue with SUReplAccessStrict mode,
The hba generated get the master listen address instead of the standby address.
This should work as expected with this fix.