Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support manual create logical replication slot #530

Closed
wants to merge 1 commit into from

Conversation

Lychangin
Copy link

@sgotti please review the pull request. This feature will be useful for example:

  • Upgrade postgres cluster without downtime
  • Logical replication for a separate database

@sgotti
Copy link
Member

sgotti commented Jul 2, 2018

@Lychangin Thanks for your PR. As I explained here I'll prefer to simplify the current logic to namespace these additional repl slots with stolon_ like already done by the repl slots used for replication by standbys. I created #531, please take a look.

While your patch is excluding logical replication slot adding more undocumented logic, in #531 I just made all the repl slots prefixed with stolon_ so users will be able to manually manage every repl slots (it just shouldn't start with stolon_).

@Lychangin
Copy link
Author

Thanks for the answer. I looked at your PR, I'm completely satisfied with it, I'll close my PR then.

@Lychangin Lychangin closed this Jul 2, 2018
@sgotti sgotti added this to the v0.12.0 milestone Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants