stolonctl spec: don't show some null clusterspec options #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* show only changed options and omit all the empty/null options * when using --defaults show ALL the options Do this by using two copies of the clusterspec struct, one with all json tags with omitempty and one without omitempty that will be casted from the original cluster spec (so we will get an error when we forgot to updated them when changing the ClusterSpec struct)
sgotti
force-pushed
the
stolonctl_spec_improve_output
branch
from
842f250 to
1796b33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do this by using two copies of the clusterspec struct, one with all json tags
with omitempty and one without omitempty that will be casted from the original
cluster spec (so we will get an error when we forgot to updated them when
changing the ClusterSpec struct)