Broken --workspace doesn't work anymore

[szpak]

--workspace doesn't seem to work anymore:

$ . gradle/install-jdk.sh -W ~/custom-java --url "https://api.adoptopenjdk.net/v2/binary/releases/openjdk11?openjdk_impl=openj9&os=linux&arch=x64&release=latest&type=jdk&heap_size=normal"
install-jdk.sh 2019-07-17
Variables:
  feature = <overridden by custom url>
       os = <overridden by custom url>
      url = https://api.adoptopenjdk.net/v2/binary/releases/openjdk11?openjdk_impl=openj9&os=linux&arch=x64&release=latest&type=jdk&heap_size=normal
   status = 302
Downloading JDK from https://api.adoptopenjdk.net/v2/binary/releases/openjdk11?openjdk_impl=openj9&os=linux&arch=x64&release=latest&type=jdk&heap_size=normal...
tar: /home/travis/custom-java: Cannot open

After local testing it seems that --output-directory overrides --directory-prefix introduced in July. It started to be visible as I use locally copied install-jdk.sh script which I just upgraded to get support for newer Java versions.

[sormuras]

Thanks for the report.

Do you have an idea how to quickly fix this as well? My current time is limited, so I won't be able to dig into for about two weeks.

[szpak]

Maybe:

local local="--output-document=${workspace}jdk-${feature}.tar.gz"

plus:

local tar_options="--file ${workspace}jdk-${feature}.tar.gz"

with some trailing "/" adding to workspace if not provided (and if workspace is not "")

However, it's Bash, nothing is easy (and testable)... Take your time, maybe I will be determined enough to get into it before that ;).