Immutable js root state #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Made a couple small changes to the README. Also we changed how the store enhancer is applied, so I reverted that. |
|
This needs to be merged into develop. I'll look into resolving the conflicts later this week, unless you want to rebase it again. |
|
I can try rebasing, I will let you know if I get stuck |
…ods (eg: redux-persist-immutable) - add config offlineStateLens: with state getter and setter and splitter for offline state vs rest - add config persistAutoRehydrate: to make it possible to inject another autoHydration (eg: redux-persist-immutable) - use offlineStateLens in the middleware and the enhancer - add the new flowtypes for the config - update the README.md
fabriziomoscon
force-pushed
the
immutable-js-root-state
branch
from
bc2cf5a
to
7109533
Compare
fabriziomoscon
commented
Oct 5, 2017
src/index.js
Outdated
| config.persist && config.rehydrate | ||
| ? compose(offlineMiddleware, autoRehydrate()) | ||
| : offlineMiddleware; | ||
| config.persist && config.rehydrate && config.persistAutoRehydrate |
There was a problem hiding this comment.
@wacii Please check that I kept the correct code for this block during the rebase
|
@wacii I have rebased on top of |
|
Nifty. I addressed your comment. Everything looks good. Thanks again. |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #37
This patch allows to use
redux-offlinewith a root immutable state.These are non breaking changes on top of
v2.1.0offlineStateLens: with state getter and setter and splitter forofflinestate vs restpersistAutoRehydrate: to inject another autoHydration (eg:redux-persist-immutable)offlineStateLensin the middleware and the enhancerconfig.persistflow typeAn auxiliary npm module providing immutable default configs has been published at: https://www.npmjs.com/package/redux-offline-immutable-config
This code has been written together with @Ashmalech