Allow to use Promises on discard function

[piranna]

This allow to return a Promise on the discard function so it's possible to decide asynchronously if a request should be discarded.

[piranna]

Any update on this? I need this for my work... :-/

[wacii]

How would you use this? Do you have a sample discard() function?

[piranna]

How would you use this?

My use case is to check when I get a 401 Unauthorized error when doing a request because the access token got expired, so I need to request for a token refresh (that's an async operation) and if it went good then retry the unauthorized request with the new token header.

Do you have a sample discard() function?

import defaults_discard from '@redux-offline/redux-offline/lib/defaults/discard'

let refresh

function setRefresh(_refresh)
{
  refresh = _refresh
}

function discard(error, action, retries)
{
  if(error.status === 401) return refresh().then(() => false)

  return defaults_discard(error, action, retries)
}

Maybe should I to update the README.md docs?

[adrianicv]

I agree with @piranna, it would be awesome to have this functionality!

[piranna]

I've added tests and documentation for returning a Promise object from discard() function.

[wacii]

I would update the signature and leave it at that.

[piranna]

What do you means?

[wacii]

Your editor appears to have inserted line breaks here. It doesn't affect the resulting document, but I'd prefer to leave them out, just for consistency.

[piranna]

I've added them myself, I'm used to 80 columns also on Markdown files. I don't like to scroll horizontally and I would change the full file instead to adjust it, but if you preffer to have it the old way I can be able to change it.

[wacii]

@piranna Thanks for the clarification. Other than some minor changes with the documentation, it looks good.

@sorodrigo is getting ready for a release, and then we are looking to merge back into the original repo, so I'm not sure when we'll get to this.

[sorodrigo]

I think its a good addition. Also, there a != somewhere near your changes, could replace it for a !==?

[sorodrigo]

I say we include this as a last addition before the next release

[wacii]

The != was there before. And I'd be good with including it now.

[sorodrigo]

Yes I know haha it’s a style choice of the previous author. But I say if we are already updating this file why not change it. But its not THAT important.

[piranna]

I think its a good addition. Also, there a != somewhere near your changes, could replace it for a !==?

delay != null allow to delay to be both null and undefined. I think it's good to have it this way and only use === when you want explicitly check for exactly only one of them...

[sorodrigo]

Ok, just make the last changes @wacii suggested and we can merge

[piranna]

Ok, just make the last changes @wacii suggested and we can merge

The one of the splitted lines on the README.md file?

[piranna]

I have removed the splitlines on README.md. Is there anything more I need to do?

[sorodrigo]

Thanks!

[piranna]

Thanks!

You are welcome! :-D Do you know when it could be published on npm? :-)