Apply post-install patch for flipper-pod #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
ios project wont build with xcode 15.3
See issue here: facebook/react-native#43335
We patch the flipper-code with a post-install script, so it works
Why was the change made?
Fix ios building
Caveats?
RN team are decoupling rn from flipper (https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0641-decoupling-flipper-from-react-native-core.md)
Flipper will still be available, but using chrome dev-tools might be more lightweight and it should work with the hermes engine when rn 0.74 comes out. Maybe something to consider, should we switch. For now, lets keep Flipper.
Related Trello issue
Link to the Trello ticket
Checklist