Skip to content

Commit

Permalink
Removes (annoying) alert on column copy value
Browse files Browse the repository at this point in the history
All other copy to clipboard action are `alert` free like copying a table name to the clipboard. I think it should be the same for copying a column value.

If you think some feedback is necessary, maybe we should see a small label showing up than closing shortly after. As a comparison, it appears GitHub, in the commit list view, does not shot any feedback anymore (is it a bug maybe? because remote url copy still shows a feedback, anyway :)).

P.S. My editor automatically removed some trailing white spaces, if you prefer, I can revert those.
  • Loading branch information
Matthieu Vachon committed Dec 8, 2021
1 parent be6ef48 commit cc1666b
Showing 1 changed file with 9 additions and 10 deletions.
19 changes: 9 additions & 10 deletions static/js/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ function resetTable() {
data("mode", "").
removeClass("empty").
removeClass("no-crop");

$("#results_header").html("");
$("#results_body").html("");
}
Expand Down Expand Up @@ -701,7 +701,7 @@ function showUniqueColumnsValues(table, column, showCounts) {
// Show numeric stats on the field
function showFieldNumStats(table, column) {
var query = 'SELECT count(1), min(' + column + '), max(' + column + '), avg(' + column + ') FROM ' + table;

executeQuery(query, function(data) {
$("#input").hide();
$("#body").prop("class", "full");
Expand Down Expand Up @@ -950,7 +950,6 @@ function bindTableHeaderMenu() {
switch(menuItem.data("action")) {
case "copy_value":
copyToClipboard($(context).text());
alert("Requested cell value has been copied to the clipboard!");
break;
case "filter_by_value":
var colIdx = $(context).data("col");
Expand Down Expand Up @@ -1074,18 +1073,18 @@ function bindContextMenus() {

function toggleDatabaseSearch() {
$("#current_database").toggle();
$("#database_search").toggle();
$("#database_search").toggle();
}

function enableDatabaseSearch(data) {
var input = $("#database_search");

input.typeahead("destroy");

input.typeahead({
source: data,
minLength: 0,
items: "all",
input.typeahead({
source: data,
minLength: 0,
items: "all",
autoSelect: false,
fitToElement: true
});
Expand Down Expand Up @@ -1283,13 +1282,13 @@ $(document).ready(function() {
enableDatabaseSearch(resp);
});
});

$("#database_search").change(function(e) {
var current = $("#database_search").typeahead("getActive");
if (current && current == $("#database_search").val()) {
apiCall("post", "/switchdb", { db: current }, function(resp) {
if (resp.error) {
alert(resp.error);
alert(resp.error);
return;
};
window.location.reload();
Expand Down

0 comments on commit cc1666b

Please sign in to comment.