[ceph_mds] Capture alternative mds file path

[jcastill]

Newer versions of Ceph place information in
/var/lib/ceph//mds* instead of
/var/lib/ceph/mds/*, so we need to capture
the new path as well.

Related: RH: SUPDEV-154

---

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

• Is the commit message split over multiple lines and hard-wrapped at 72 characters?
• Is the subject and message clear and concise?
• Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
• Does the commit contain a Signed-off-by: First Lastname email@example.com?
• Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
• Are all passwords or private data gathered by this PR obfuscated?

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/sosreport-sos-3645
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[arif-ali]

@jcastill is it not worth adding to add_copy_spec below as well?

[jcastill]

@jcastill is it not worth adding to add_copy_spec below as well?

oh wow, I completely missed that. I'll add it and push again, thank you @arif-ali !

[arif-ali]

@jcastill is it not worth adding to add_copy_spec below as well?

oh wow, I completely missed that. I'll add it and push again, thank you @arif-ali !

alternatively, we could just call super().setup() at the end and remove the copy_spec for those specific files, as that already does this. I'm not sure why we're not already doing that, when the Plugin class can do this for us already. Something to think about on other plugins too

[pmoravec]

@jcastill is it not worth adding to add_copy_spec below as well?

oh wow, I completely missed that. I'll add it and push again, thank you @arif-ali !

alternatively, we could just call super().setup() at the end and remove the copy_spec for those specific files, as that already does this. I'm not sure why we're not already doing that, when the Plugin class can do this for us already. Something to think about on other plugins too

I was under the impression this is done automatically..? It imho makes sense to collect files by default, no?

[arif-ali]

alternatively, we could just call super().setup() at the end and remove the copy_spec for those specific files, as that already does this. I'm not sure why we're not already doing that, when the Plugin class can do this for us already. Something to think about on other plugins too

I was under the impression this is done automatically..? It imho makes sense to collect files by default, no?

That was my original impression too, but the only place in the Plugin class we are is in the setup() function. Maybe we need some improvements here. I did a quick search for self.files in __init__py, we only find one scenario where we are collecting from that dict, and that is in the setup(), but because we always override it, we don't collect anything from the dict

[arif-ali]

@pmoravec you have proved me wrong, just tested the same for the cron plugin, which only has /etc/crontab in files but nowhere else. So, this looks good to me :)

[pmoravec]

@pmoravec you have proved me wrong, just tested the same for the cron plugin, which only has /etc/crontab in files but nowhere else. So, this looks good to me :)

But we add_copy_spec the glob /etc/cron* - when I comment it out, /etc/crontab stops to be collected.

add_default_collections method does (all?) such automatic collection from plugins triggers.

Since we touched a topic we are not certain about proper behaviour, I kicked off discussion on it in https://github.com/orgs/sosreport/discussions/3647 .

[arif-ali]

@pmoravec you have proved me wrong, just tested the same for the cron plugin, which only has /etc/crontab in files but nowhere else. So, this looks good to me :)

But we add_copy_spec the glob /etc/cron* - when I comment it out, /etc/crontab stops to be collected.

Dunno why, but I overlooked that bit :), good catch