-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[oracle] Add initial implementation of oracle plugin #3889
[oracle] Add initial implementation of oracle plugin #3889
Conversation
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
557399c
to
d6d8fed
Compare
sos/report/plugins/oratab.py
Outdated
# don't gather duplicate files | ||
path_list = set() | ||
|
||
with open(ora_tab, 'r', encoding='UTF-8') as ofile: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we opening the file again, and assigning to ofile
again?
Related: RHEL-59870, TYCHE-732 Signed-off-by: David Wolstromer <dwolstro@redhat.com>
Related: RHEL-59870, TYCHE-732 Signed-off-by: David Wolstromer <dwolstro@redhat.com>
d6d8fed
to
9b34a23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any oratab to check against, so from a plugin perspective all good
Related: RHEL-59870, TYCHE-732
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines