Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oracle] Add initial implementation of oracle plugin #3889

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

dwolstroRH
Copy link
Contributor

Related: RHEL-59870, TYCHE-732


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

@arif-ali arif-ali added Status/Needs Review This issue still needs a review from project members Kind/New plugin New plugin being added labels Dec 19, 2024
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3889
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

sos/report/plugins/oracle.py Outdated Show resolved Hide resolved
sos/report/plugins/oracle.py Outdated Show resolved Hide resolved
sos/report/plugins/oracle.py Outdated Show resolved Hide resolved
sos/report/plugins/oracle.py Outdated Show resolved Hide resolved
@dwolstroRH dwolstroRH force-pushed the RHEL-59870_oracle_plugin branch from 557399c to d6d8fed Compare January 21, 2025 21:12
# don't gather duplicate files
path_list = set()

with open(ora_tab, 'r', encoding='UTF-8') as ofile:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we opening the file again, and assigning to ofile again?

@arif-ali arif-ali added the Status/Need More Info Feedback is required to reproduce issue or to continue work label Jan 31, 2025
Related: RHEL-59870, TYCHE-732

Signed-off-by: David Wolstromer <dwolstro@redhat.com>
Related: RHEL-59870, TYCHE-732

Signed-off-by: David Wolstromer <dwolstro@redhat.com>
@dwolstroRH dwolstroRH force-pushed the RHEL-59870_oracle_plugin branch from d6d8fed to 9b34a23 Compare February 4, 2025 19:55
Copy link
Member

@arif-ali arif-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any oratab to check against, so from a plugin perspective all good

@arif-ali arif-ali added Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer and removed Status/Need More Info Feedback is required to reproduce issue or to continue work labels Feb 5, 2025
@TurboTurtle TurboTurtle added Reviewed/Ready for Merge Has been reviewed, ready for merge and removed Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer Status/Needs Review This issue still needs a review from project members labels Feb 6, 2025
@TurboTurtle TurboTurtle merged commit e6ab26d into sosreport:main Feb 6, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind/New plugin New plugin being added Reviewed/Ready for Merge Has been reviewed, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants